Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add support for bucket policy only #139

Conversation

FanchenBao
Copy link
Contributor

The magic-module source file resource_storage_bucket.go has been updated to include support for bucket_policy_only. This file was modified to reflect such update

@FanchenBao
Copy link
Contributor Author

Referring to #135

@morgante
Copy link
Contributor

Thanks for the contribution! I believe this change needs to be made upstream.

@morgante morgante closed this Jul 30, 2019
@FanchenBao
Copy link
Contributor Author

@morgante Thanks for pointing out the upstream file. I wasn't aware of that. Maybe I can open a PR at the upstream file.

modular-magician pushed a commit to modular-magician/terraform-google-conversion that referenced this pull request Oct 7, 2019
…gen-pr-920

Ignore empty json objects inside arrays
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants